Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Hyrax hiding again #136

Closed
wants to merge 17 commits into from
Closed

Make Hyrax hiding again #136

wants to merge 17 commits into from

Conversation

Antonio95
Copy link
Contributor

Description

As discussed, I have reverted back to its original definition by removing the evaluation-commitment randomness from the proof and ignoring the claimed-value argument in check. Tests pass.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Antonio95 and others added 17 commits October 25, 2023 10:04
@Antonio95
added hyrax PCS
f13a576
@mmagician
adapt the scheme to arkworks-rs/algebra#691
69896d4
@mmagician
remove unused code in hyrax
ecf73f4
@Antonio95
expanded on Future Optimisations section
f424c48
@mmagician
Merge branch 'master' into hyrax-pcs
dd58a1a
@mmagician
Remove Prepared data types from PolynomialCommitment trait impl
06c59e9
@Antonio95
merged master including new crate and directory structure
a845018
@Antonio95
added necessary dependencies overwritten by previous merge commit
12afb33
@Antonio95 @mmagician
fixed hashbrown version
6967c28
@Antonio95
pulled
dd82dbc
@Antonio95
created separate benchmark files
a029081
@Antonio95
fixed duplicate dependency to match other branches
a7f465a
@Antonio95
patched bn254 dep
c010663
@Antonio95
restructured benchmark macros to accept ML schemes; benches working
d415053
@mmagician
Hyrax fix bench (#42)
3ef7309 
* fix bench call

* set num vars from 12-20
@mmagician
Hyrax parallel commit (#39)
cc1f75a 
* Enable parallel commitment in hyrax

amend

* make `rand` optional

* remove dead code
@Antonio95
removed evaluation randomness from proof and ignored claimed value in…
a806044 
… check to make scheme hiding
@Antonio95 Antonio95 requested a review from a team as a code owner November 13, 2023 10:59
@Antonio95 Antonio95 requested review from z-tech, Pratyush and mmagician and removed request for a team November 13, 2023 10:59
@Antonio95 Antonio95 closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antonio95 @mmagician